gaobinlong commented on PR #15879: URL: https://github.com/apache/lucene/pull/15879#issuecomment-4152647686
> Do we have any benchmarks to show the improvement? It seems intuitive to me that there should be nice improvements. Thanks @benwtrent , the current code in the benchmark tool luceneutil doesn't cover the TopGroups.merge() method, I cherry-picked [the code in the opening PR which introduces TopGroupsCollectorManager](https://github.com/apache/lucene/pull/15603/changes#diff-f72bcee3487aff465e3b01e31f6e5fedaa4c0877cc755bb7eeed9c859802f8fdR135) and then did benchmark test for this optimization, here're the result: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value TermGroup10K 43.17 (5.1%) 43.51 (7.6%) 0.8% ( -11% - 14%) 0.700 TermGroup1M 24.44 (6.3%) 24.79 (9.4%) 1.5% ( -13% - 18%) 0.565 TermGroup100 104.37 (6.9%) 108.18 (8.8%) 3.6% ( -11% - 20%) 0.145 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
