dweiss commented on code in PR #15874:
URL: https://github.com/apache/lucene/pull/15874#discussion_r3020381563
##########
lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/BytesTermAttributeImpl.java:
##########
@@ -70,8 +70,9 @@ public void reflectWith(AttributeReflector reflector) {
@Override
public boolean equals(Object o) {
if (this == o) return true;
- if (!(o instanceof BytesTermAttributeImpl)) return false;
- BytesTermAttributeImpl that = (BytesTermAttributeImpl) o;
+ if (!(o instanceof BytesTermAttributeImpl that)) {
Review Comment:
Ok, we don't run unused variable checks; I swear we did once. Maybe we
should restore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
