uschindler commented on PR #15900: URL: https://github.com/apache/lucene/pull/15900#issuecomment-4172211821
I think the TruncateTokenFilter is somehow broken in general, because it only counts 16bit java characters - @rmuir. The question is more if we need a "valid" tokenfilter that counts the codepoints and not chars and strips after length's codepoint. At least we should add a truncation that takes care of that and deprecate the old one. Because an Emoji is still only one codepoints. The java char length is not really useful as in index the token is saved as UTF-8, so we should be standards conformant. I am not sure how to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
