uschindler commented on PR #15900: URL: https://github.com/apache/lucene/pull/15900#issuecomment-4177550840
Hi, sure. Will put a comment into the issue https://github.com/apache/lucene/issues/15899. I think we should now decide how to proceed: - Keep the old filter as is but update its documentation that it works on Java Chars / UTF-16 and not on codepoints and therefor may split them inbetween? The new Filter as listed above would have a new name `CodepointTruncateFilter` - Modify the current filter like the NGram ones that were changed in Lucene 4.4 (see the note in javadocs): <img width="1088" height="352" alt="image" src="https://github.com/user-attachments/assets/392b2dfd-583d-4247-8a7a-f47de36d0ee6"; /> So how should we proceed: New filter or not? > add a test case where length==1 and there is a single emoji in the input? I added a line in above test with a single character and a single emoji. Works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
