uschindler commented on issue #15899: URL: https://github.com/apache/lucene/issues/15899#issuecomment-4177576895
Hi, see the #15900. Actually we should change the filter to behave correctly. A Unicode-confirm Truncate filter that splits after "n" codepoints (not utf-16 chars) was developed already and should be used instead of the current code. We modified all other similar filters in the past (like ngrams), they all work correctly. We have one filter (LengthFilterTokenFilter) that has two variants (it drops too long tokens). The unicode variant has a different name (with term codepoints). There are 2 solutions: - Keep current filter unmodified (like LengthFilter) and add a warning to Javadocs - Modify the filter to Truncate at codepoints Both is fine, we just need a decission. The new filter's code is here: https://github.com/apache/lucene/pull/15900#issuecomment-4175882033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
