uschindler commented on PR #15900: URL: https://github.com/apache/lucene/pull/15900#issuecomment-4182974383
An alternative would be to change the TokenFilter to take a boolean in its ctor `useCodepoints` which defaults to false in 10.x branch and to true in main. The factory for CustomAnalyzer and Solr could be changed to use two incompatible names in the configuration map: - if you set `prefixLength` it uses the old buggy behaviour and logs a warning that it is deprecated - if you set `truncateAfterCodepoints` it uses new behaviour - this also allows to rename the configuration parameter - if you set both it bails out The code in the filter itsself is a trivial if/else. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
