javanna commented on PR #15565: URL: https://github.com/apache/lucene/pull/15565#issuecomment-4235923103
Thanks for opening this PR @gaobinlong ! I had a quick look and my observations are similar to those I had at https://github.com/apache/lucene/pull/15557#issuecomment-4235791234 . We are introducing a new public collector manager that is only used in tests code, while the grouping collector code (`GroupingSearch`) requires some rework to rely on collector managers. I wonder if we should start with working on that, which looks though involving, or simply update the test so that it no longer relies on a collector manager. All in all an important longer term question is how are grouping users going to move from collectors to collector managers. Lucene should probably include the building blocks for them to do so, and we need to define which those are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
