mikemccand commented on code in PR #15978:
URL: https://github.com/apache/lucene/pull/15978#discussion_r3154858933
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -339,17 +376,10 @@ public void addGraphNode(int node, IntHashSet eps0)
throws IOException {
addGraphNodeInternal(node, scorer, eps0);
}
- private long printGraphBuildStatus(int node, long start, long t) {
- long now = System.nanoTime();
+ private void printGraphBuildStatus(int node, long startNs) {
+ double elapsedMs = (System.nanoTime() - startNs) / 1_000_000.0;
Review Comment:
Hmm, can we be consistent about `startNs` vs `chunkElapsedNS` ("treat it
like a word" --> `chunkedElapsedNs`)? Darned camel-casing rules intersecting
with acronyms/abbreviations... Wikipedia's CamelCase page has a [whole
paragraph dedicated to the
conundrum](https://en.wikipedia.org/wiki/Camel_case#Programming_and_coding:~:text=lower%20camel%20case.-,Programming,-identifiers%20often%20need).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
