javanna commented on PR #15608: URL: https://github.com/apache/lucene/pull/15608#issuecomment-4358838146
hi @prudhvigodithi thanks opening this PR. I commented on the issue that this PR addresses (see https://github.com/apache/lucene/issues/15605#issuecomment-4358830104). In short I am not sure that this PR fixes a real bug, and I believe supporting concurrency in `newCollector` would be controversial unless we confirm that it's a supported usecase. I would vote for instead deprecating and removing the unused `getCollectors` method and perhaps better document where thread safety is guaranteed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
