rmuir commented on PR #16031: URL: https://github.com/apache/lucene/pull/16031#issuecomment-4379351176
> Hosts that already do request-scoped accounting for the rest of the family, `RegexpQuery`, `WildcardQuery`, `PrefixQuery`, `TermRangeQuery`, all of which expose their compiled-automaton cost through `Accountable#ramBytesUsed()` because they retain the automaton. Currently can't extend the same scheme to `FuzzyQuery`, because FuzzyQuery deliberately doesn't retain its automata on the query. I guess this is what I'm disputing. It isn't really "in the family" since it builds a small DFA correctly. It doesn't have unpredictable size and runtime like Regexp or Wildcard. I'm worried if we expose too many guts for these small things, it will hinder future improvements. For this one, a good future improvement would be to look at removing tableization if we don't need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
