Tibor17 commented on a change in pull request #213: [SUREFIRE-1534]
ClassNotFoundException:
org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks
set to false
URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249286371
##########
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -114,7 +114,8 @@ public void platform() throws VerificationException
+ " surefire-api-*.jar"
+ " surefire-logger-api-*.jar"
+ " common-java5-*.jar"
- + " junit-platform-launcher-1.3.1.jar";
+ + " junit-platform-launcher-1.3.1.jar"
+ + " maven-surefire-common-*.jar";
Review comment:
The artifact `maven-surefire-common` should present on `in-plugin` CP, but
it should not present on forked CP. Let's compare `AbstractSurefireMojo` with
the version `2.20.1` and we should see the regression. It would be worth to
control `forkCount=0/1` in the parameterized test
`JUnitPlatformEnginesIT.java`. In principle the test result should be the same
however the provider CP should see the difference with the present of the
problematic artifact `maven-surefire-common`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
