[ 
https://issues.apache.org/jira/browse/MNG-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008325#comment-17008325
 ] 

Ross Goldberg edited comment on MNG-6420 at 1/5/20 1:11 PM:
------------------------------------------------------------

What are the next steps?

In what Maven versions can any of the following be done (3.6.x, 3.7, or 4.0)?

 # clarify spec (i.e. rewrite spec so that it is clearer, but without changing 
the outcomes from the existing spec)
 # change spec (i.e. change outcomes defined by spec)
 # fix inconsistencies between any of the following with the spec and/or each 
other: canonical, compareTo, equals, hashCode, toString

What are the approval requirements for each of the above?

Are the releases of 3.6.4, 3.7, and/or 4.0 scheduled?


was (Author: xdr):
What are the next steps?

In what Maven versions can any of the following be done (3.6.x, 3.7, or 4.0)?

 # clarify spec (i.e. rewrite spec so that it is clearer, but without changing 
the outcomes from the existing spec)
 # change spec (i.e. change outcomes defined by spec)
 # fix inconsistencies between any of the following with the spec and/or each 
other: canonical, compareTo, equals, hashCode, toString

Are the releases of 3.6.4, 3.7, and/or 4.0 scheduled?

> ComparableVersion incorrectly parses certain version strings
> ------------------------------------------------------------
>
>                 Key: MNG-6420
>                 URL: https://issues.apache.org/jira/browse/MNG-6420
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.5.3, 3.6.3
>            Reporter: Ross Goldberg
>            Priority: Major
>
> For certain version strings, ComparableVersion doesn't follow the Maven 
> version order spec 
> (https://maven.apache.org/pom.html#Version_Order_Specification), and/or 
> produces canonical versions that are incongruent with both the spec and the 
> code's ordering.
> To improve the code & fix the following bugs, I completely rewrote the 
> version parser (using Java 8).  I will create a PR sometime soon.
> *Bug 1: comparison violates spec ordering*
>  
> java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.6.3.jar 
> 1-0.3 1
>  
> Outputs:
>  
> 1. 1-0.3 == 1-0.3
>    1-0.3 == 1
> 2. 1 == 1
>  
> This problem stems from:
>  
> [https://github.com/apache/maven/blob/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L295-L296]
>  
>  
>  
> *Bug 2: canonical incongruent with spec and code ordering*
>  
> java -jar /usr/local/Cellar/maven/3.5.3/libexec/lib/maven-artifact-3.6.3.jar 
> 1-0-2 1-0.1
>  
> 1. 1-0-2 == 1-2
>    1-0-2 < 1-0.1
> 2. 1-0.1 == 1-0.1
>  
> This problem stems from retaining ListItems that, after normalization, have 
> no children other than the subsequent ListItem.  Removing the unnecessary 
> ListItem should fix this (i.e. remove the extraneous ListItem (named 
> extraneous) from its parent ListItem (named parent), then add the only child 
> of extraneous to parent).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to