[ 
http://jira.codehaus.org/browse/MAVENUPLOAD-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=133486#action_133486
 ] 

Matt Raible commented on MAVENUPLOAD-2048:
------------------------------------------

I believe these dependencies are wrong (from a scope perspective) and should be 
fixed. Currently:

        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>3.8.1</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>servlet-api</artifactId>
            <version>2.3</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>ant</groupId>
            <artifactId>ant</artifactId>
            <version>1.5</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>log4j</groupId>
            <artifactId>log4j</artifactId>
            <version>1.2.8</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>commons-logging</groupId>
            <artifactId>commons-logging</artifactId>
            <version>1.0</version>
            <scope>compile</scope>
        </dependency>

Suggested:

        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>3.8.1</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>servlet-api</artifactId>
            <version>2.3</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>ant</groupId>
            <artifactId>ant</artifactId>
            <version>1.5</version>
            <optional>true</optional>
        </dependency>
        <dependency>
            <groupId>log4j</groupId>
            <artifactId>log4j</artifactId>
            <version>1.2.8</version>
            <optional>true</optional>
        </dependency>
        <dependency>
            <groupId>commons-logging</groupId>
            <artifactId>commons-logging</artifactId>
            <version>1.0</version>
            <optional>true</optional>
        </dependency>

Also, are the last 3 even necessary - does the UrlRewriteFilter require any of 
them to run? Should the only dependency should be the servlet-api?

> Upload UrlRewriteFilter 3.1.0
> -----------------------------
>
>                 Key: MAVENUPLOAD-2048
>                 URL: http://jira.codehaus.org/browse/MAVENUPLOAD-2048
>             Project: maven-upload-requests
>          Issue Type: Task
>            Reporter: Paul Tuckey
>
> UrlRewriteFilter
> Based on the popular and very useful mod_rewrite for apache, UrlRewriteFilter 
> is a Java Web Filter for any J2EE
> compliant web application server (such as Resin, Orion or Tomcat), which 
> allows you to rewrite URLs before they get to
> your code. It is a very powerful tool just like Apache's mod_rewrite.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to