ChrisSamo632 commented on pull request #4822:
URL: https://github.com/apache/nifi/pull/4822#issuecomment-839077520


   @turcsanyip I've implemented a check in `onTrigger` to ensure the 
`WorkerState` never reaches `SHUT_DOWN` without the `ConsumeKinesisStream` 
processor being Stopped in NiFi - this is the only way I can see of trying to 
check whether the Worker has failed to initialise (it would remain at `CREATED` 
or `INITIALIZING` state until finally shutting down due to a configuration 
error).
   
   Unit test added to show the behaviour (happily the unit tests don't connect 
to a Kinesis/DynamoDB instance so the Worker always fails eventually, now we 
throw a `ProcessException` to note that in the NiFi UI and allow a Bulletin to 
be generated).
   
   Newer KCL versions allow for better handling of this scenario, but we're 
limited to when we can do in KCL 1.13.3 (see NIFI-8531 for upgrading to KCL 2.x 
and a note about improving this scenario).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to