Lehel44 commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r630573717
########## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/dto/SNMPResponse.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.snmp.dto; + +import org.apache.nifi.snmp.utils.SNMPUtils; +import org.snmp4j.PDU; +import org.snmp4j.Target; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public class SNMPResponse { + + private final Map<String, String> attributes; + private final List<SNMPValue> variableBindings; + private final int errorStatus; + private final String errorStatusText; + private final String targetAddress; + + public SNMPResponse(final PDU responsePdu, final Target target) { + attributes = SNMPUtils.getPduAttributeMap(responsePdu); Review comment: I extract information on the fly when SNMP Get is being called here: [line](https://github.com/apache/nifi/blob/e121973906f72899354011fdeeb48538fba99a94/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/operations/StandardSNMPRequestHandler.java#L72) We extract the information only once, why do you think we should store it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
