[
https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074756#comment-17074756
]
Hadoop QA commented on PHOENIX-5799:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12998770/PHOENIX-5799-4.x.v1.patch
against 4.x branch at commit 40bcc0184d3f7257ba2ce98b045d6e8a41f58a00.
ATTACHMENT ID: 12998770
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ TableName indexToolResultTable =
TableName.valueOf(IndexVerificationResultRepository.RESULT_TABLE_NAME_BYTES);
+ int offset = Bytes.indexOf(rowKey,
IndexVerificationResultRepository.ROW_KEY_SEPARATOR_BYTE);
+ IndexVerificationOutputRepository.DATA_TABLE_NAME_BYTES,
0, IndexVerificationOutputRepository.DATA_TABLE_NAME_BYTES.length) == 0) {
+ IndexVerificationOutputRepository.INDEX_TABLE_NAME_BYTES,
0, IndexVerificationOutputRepository.INDEX_TABLE_NAME_BYTES.length) == 0) {
+ IndexVerificationOutputRepository.ERROR_MESSAGE_BYTES, 0,
IndexVerificationOutputRepository.ERROR_MESSAGE_BYTES.length) == 0) {
+ TableName indexToolOutputTable =
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME_BYTES);
+ IndexVerificationOutputRow expectedRow =
buildVerificationRow(dataRowKey, indexRowKey, dataRowTs,
+ byte[]
expectedValue, byte[] actualValue,
+ conn.createStatement().execute("upsert into " + tableName + " values
('a', 'ab', 'abc', 'abcd')");
+ resultRepository.logToIndexToolResultTable(expectedResult,
IndexTool.IndexVerifyType.BOTH,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientHashAggregateIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3716//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3716//console
This message is automatically generated.
> Inline Index Verification Output API
> ------------------------------------
>
> Key: PHOENIX-5799
> URL: https://issues.apache.org/jira/browse/PHOENIX-5799
> Project: Phoenix
> Issue Type: Bug
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5799-4.x.v1.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Followup from PHOENIX-5773 -- split out the logic in
> IndexRebuildRegionScanner that writes to the output table into its own class,
> plus add read methods and tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
