joshelser commented on a change in pull request #31:
URL: https://github.com/apache/phoenix-queryserver/pull/31#discussion_r418335393
##########
File path: python/phoenixdb/README.rst
##########
@@ -85,12 +70,15 @@ the `PYTHONPATH` environment variable to point to the
library directly::
cd ~/my_project
PYTHONPATH=$PHOENIX_HOME/build/lib python my_app.py
+Don't forget to run flake8 on your changes.
+
Interactive SQL shell
---------------------
There is a Python-based interactive shell include in the examples folder,
which can be
used to connect to Phoenix and execute queries::
+ pip install -r ./examples/requirements.txt
./examples/shell.py http://localhost:8765/
Review comment:
```
➜ [email protected] % ./examples/shell.py http://localhost:8765/
Traceback (most recent call last):
File "./examples/shell.py", line 20, in <module>
import sqlline
File
"/Users/jelser/projects/phoenix-queryserver.git/python/phoenixdb/e/src/sqlline/sqlline/__init__.py",
line 1, in <module>
from sqlline.shell import SqlLine
File
"/Users/jelser/projects/phoenix-queryserver.git/python/phoenixdb/e/src/sqlline/sqlline/shell.py",
line 100
print "!autocommit Set autocommit mode on or off"
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean
print("!autocommit Set autocommit mode on or off")?
```
Do you already know that this apparently doesn't work on python3? I guess
Lukas's sqlline python wrapper is just not updated?
##########
File path: python/phoenixdb/README.rst
##########
@@ -65,17 +56,11 @@ necessary requirements::
pip install -r requirements.txt
python setup.py develop
-To create or update the Avatica protobuf classes, change the tag in
``gen-protobuf.sh``
-and run the script.
-
-If you need a Phoenix query server for experimenting, you can get one running
-quickly using `Docker <https://www.docker.com/>`_::
+You can start a Phoenix QueryServer test instance on http://localhost:8765 for
testing by running
+the following command in the phoenix-queryserver directory:
- docker-compose up
-
-Or if you need an older version of Phoenix::
-
- PHOENIX_VERSION=4.9 docker-compose up
+ mvn clean verify -am -pl queryserver-it -Dtest=foo
-Dit.test=QueryServerBasicsIT#startLocalPQS \
Review comment:
Making this `QueryServerBasicsIT\#startLocalPQS` would help people like
me with zsh (which interpolates the # as a comment ;) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
