[ 
https://issues.apache.org/jira/browse/PHOENIX-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109296#comment-17109296
 ] 

Hadoop QA commented on PHOENIX-5899:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13003162/PHOENIX-5899.4.x.patch
  against 4.x branch at commit 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a.
  ATTACHMENT ID: 13003162

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                Throwable cause = 
ServerUtil.getExceptionFromFailedFuture(resultsAndFutures.getSecond().get(index));
+                Throwable cause = 
ServerUtil.getExceptionFromFailedFuture(resultsAndFutures.getSecond().get(index));
+  public MultiIndexWriteFailureException(List<HTableInterfaceReference> 
failures, boolean disableIndexOnFailure,
+  public <R> Pair<List<R>, List<Future<R>>> submit(TaskBatch<R> tasks) throws 
CancellationException, ExecutionException,
+      return Pair.newPair(submitTasks(futures).get(), 
Collections.unmodifiableList(((List<Future<R>>)(List<?>)futures)));
+  public <R> Pair<List<R>, List<Future<R>>> submitUninterruptible(TaskBatch<R> 
tasks) throws EarlyExitFailure,
+  public <R> Pair<List<R>, List<Future<R>>> submitUninterruptible(TaskBatch<R> 
tasks) throws EarlyExitFailure,
+            MultiIndexWriteFailureException exception = new 
MultiIndexWriteFailureException(Collections.unmodifiableList(failedTables),
+                    disableIndexOnFailure && 
PhoenixIndexFailurePolicy.getDisableIndexOnFailure(env), cause);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.RollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.replication.SystemCatalogWALEntryFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.util.IndexScrutinyIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinPersistentCacheIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3860//testReport/
Code Coverage results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3860//artifact/phoenix-core/target/site/jacoco/index.html
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3860//console

This message is automatically generated.

> Index writes and verifications should contain information of underlying cause 
> of failure
> ----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5899
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5899
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5899.4.x.patch, PHOENIX-5899.4.x.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In case of any failures during index writes, rebuild and verify we simply 
> returnĀ 
> MultiIndexWriteFailureException without the underlying cause. This makes 
> finding the underlying root cause exceptionally hard.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to