[ 
https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242099#comment-17242099
 ] 

ASF GitHub Bot commented on PHOENIX-5728:
-----------------------------------------

virajjasani commented on pull request #990:
URL: https://github.com/apache/phoenix/pull/990#issuecomment-737036878


   > This also seems to be low risk, as it doesn't change existing 
functionality.
   
   That's correct, and that's the reason this should not cause any regression.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> ExplainPlan with plan as attributes object, use it for BaseStatsCollectorIT
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-5728
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5728
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.1.0, 4.15.1
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.16.1, 4.17.0
>
>         Attachments: PHOENIX-5728.master.000.patch, 
> PHOENIX-5728.master.000.patch
>
>
> Provide -golden files- attributes based object for QueryPlan result 
> comparison for all abstract test class BaseStatsCollectorIT that includes 
> tests of all stats collections including:
>  * NamespaceDisabledStatsCollectorIT
>  * NamespaceEnabledStatsCollectorIT
>  * NonTxStatsCollectorIT
>  * TxStatsCollectorIT
> Object based ExplainPlan can be useful for quite precise comparison of 
> individual and relevant plan attributes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to