gokceni commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535777422
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##########
@@ -195,7 +207,7 @@ public static void serializeServerMaintainedIndexes(PTable
dataTable, ImmutableB
if (onlyLocalIndexes) {
if (!dataTable.isTransactional()
||
!dataTable.getTransactionProvider().getTransactionProvider().isUnsupported(Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER))
{
- indexesItr = maintainedLocalIndexes(indexes.iterator());
+ indexesItr =
maintainedLocalOrGlobalIndexesWithoutMatchingStorageScheme(dataTable,
indexes.iterator());
Review comment:
Unfortunately onlyLocalIndexes variable name is misleading. So it is
immutableIndexes or transactional indexes
boolean onlyLocalIndexes = dataTable.isImmutableRows() ||
dataTable.isTransactional();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
