[ 
https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245018#comment-17245018
 ] 

Viraj Jasani commented on PHOENIX-5728:
---------------------------------------

Thanks for the review [~stoty] [~gjacoby] and also for the idea of replacing 
gold file based check to object based Plan check by providing new API.

>From parent Umbrella Jira, I will create more sub-tasks to cover all tests 
>gradually.

Thanks

> ExplainPlan with plan as attributes object, use it for BaseStatsCollectorIT
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-5728
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5728
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 4.15.0, 5.1.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5728.4.x.000.patch, 
> PHOENIX-5728.master.000.patch, PHOENIX-5728.master.000.patch, 
> PHOENIX-5728.master.001.patch
>
>
> Provide -golden files- attributes based object for QueryPlan result 
> comparison for all abstract test class BaseStatsCollectorIT that includes 
> tests of all stats collections including:
>  * NamespaceDisabledStatsCollectorIT
>  * NamespaceEnabledStatsCollectorIT
>  * NonTxStatsCollectorIT
>  * TxStatsCollectorIT
> Object based ExplainPlan can be useful for quite precise comparison of 
> individual and relevant plan attributes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to