stoty commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-740393206


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ 4.x-PHOENIX-5923 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  10m 48s |  4.x-PHOENIX-5923 passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  4.x-PHOENIX-5923 passed  |
   | +1 :green_heart: |  checkstyle  |   1m  7s |  4.x-PHOENIX-5923 passed  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  4.x-PHOENIX-5923 passed  |
   | +0 :ok: |  spotbugs  |   2m 53s |  phoenix-core in 4.x-PHOENIX-5923 has 
946 extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 56s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m  9s |  phoenix-core: The patch generated 38 
new + 1496 unchanged - 19 fixed = 1534 total (was 1515)  |
   | +1 :green_heart: |  whitespace  |   0m  1s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m  8s |  phoenix-core generated 1 new + 944 
unchanged - 2 fixed = 945 total (was 946)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 192m 33s |  phoenix-core in the patch failed.  |
   | -1 :x: |  asflicense  |   0m 41s |  The patch generated 1 ASF License 
warnings.  |
   |  |   | 224m 45s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  index must be non-null but is marked as nullable  At 
IndexMaintainer.java:is marked as nullable  At IndexMaintainer.java:[line 188] |
   | Failed junit tests | TEST-[RangeScanIT_0] |
   |   | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/993 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile |
   | uname | Linux cd2a74a09081 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x-PHOENIX-5923 / a3df4dc |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 6250 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to