cpoerschke commented on pull request #196: URL: https://github.com/apache/solr/pull/196#issuecomment-870063569
> How are you arriving at the resulting changes after removing some of the files? For example, in the original PR, the changes to DeleteBackupCmd seem pretty uninteresting but they don't meet your filter criteria. > > [4270665#diff-32efc1930aa64502a943c1bd808c028d923a079be6fcc3465a753edf52c11dfa](https://github.com/apache/solr/commit/42706659709105bd7d013ddc90b552ef4f00b92f#diff-32efc1930aa64502a943c1bd808c028d923a079be6fcc3465a753edf52c11dfa) It's a fairly straightforward python script which line by line compares file content before and after the changes, if all the differences in a file can be "explained" via a set of transformations then the file is categorised as "easy" or "medium" and otherwise it's suggested for removal from pull request scope. `DeleteBackupCmd` did not get classified as "easy" because of the `NamedList results` to `NamedList<Object>` signature changes which are "medium". `DeleteBackupCmd` also did not get classified as "medium" because of the `NamedList` to `NamedList<Integer>` change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
