cpoerschke commented on a change in pull request #193:
URL: https://github.com/apache/solr/pull/193#discussion_r666081011
##########
File path: solr/solr-ref-guide/src/circuit-breakers.adoc
##########
@@ -27,23 +27,16 @@ If circuit breakers are enabled, requests may be rejected
under the condition of
It is up to the client to handle this error and potentially build a retrial
logic as this should ideally be a transient situation.
== Circuit Breaker Configurations
-All circuit breaker configurations are listed in the `<circuitBreaker>` tags
in `solrconfig.xml` as shown below:
+All circuit breaker configurations are listed as independent
`<circuitBreaker>` entries in solrconfig.xml as shown below:
[source,xml]
----
-<circuitBreaker class="solr.CircuitBreakerManager" enabled="true">
- <!-- All specific configs in this section -->
-</circuitBreaker>
+ <circuitBreaker
class="org.apache.solr.util.circuitbreaker.CPUCircuitBreaker" enable="true">
+ <int name="threshold">75</int>
+ </circuitBreaker>
Review comment:
minor: keep existing indentation level
```suggestion
<circuitBreaker
class="org.apache.solr.util.circuitbreaker.CPUCircuitBreaker" enable="true">
<int name="threshold">75</int>
</circuitBreaker>
```
##########
File path: solr/solr-ref-guide/src/circuit-breakers.adoc
##########
@@ -27,23 +27,16 @@ If circuit breakers are enabled, requests may be rejected
under the condition of
It is up to the client to handle this error and potentially build a retrial
logic as this should ideally be a transient situation.
== Circuit Breaker Configurations
-All circuit breaker configurations are listed in the `<circuitBreaker>` tags
in `solrconfig.xml` as shown below:
+All circuit breaker configurations are listed as independent
`<circuitBreaker>` entries in solrconfig.xml as shown below:
Review comment:
post merge conflict resolving tweak:
```suggestion
All circuit breaker configurations are listed as independent
`<circuitBreaker>` entries in `solrconfig.xml` as shown below:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
