[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410478#comment-17410478
]
Andrzej Bialecki commented on SOLR-15616:
-----------------------------------------
The XML config changes are ok, but the way it is passed to MetricConfig bothers
me ... it adds a very specific arg to the constructor, which is (presumably)
only one of a potentially larger class of "caching" params we may want to add
later. Are we going to keep extending the list of args as we add the caching of
other gauge types?
I would probably model the caching parameters as a separate bean, or at least a
Map<String, Object>.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Attachments: SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
