[
https://issues.apache.org/jira/browse/SOLR-15644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419025#comment-17419025
]
Dawid Weiss commented on SOLR-15644:
------------------------------------
I'm sorry, I don't think I understand. You're right that I don't see the
thousand issues Solr has but I see the pull request here and I struggle to see
how it's beneficial over what the runner implements.
bq. Right now it matters little - most tests are super inefficient and slow,
the universal 10 second linger gives lots of time, other waits like the up to
60 second wait for closed objects is in affect, god knows what else I’m
forgetting. And so long shutdowns, pushing to the end of lingering, and then
interrupt whatever remains, maybe retry a little, it’s all in the same noise.
There's been a lot of thought put into how this works, actually. Thread leak
lingering is optional as is throwing exceptions on detecting threads that
escaped the scope. If you want to end fast and not see any exceptions, set this
on the test you're working on:
{code}
ThreadLeakScope(Scope.SUITE)
ThreadLeakLingering(linger = 100)
ThreadLeakAction({Action.WARN})
{code}
Thread lingering was added to deal with thread executors - there is no way to
ensure thread executor' threads are done (terminated state), even if the
executor itself is shut down properly.
> Add the ability to interrupt and wait for threads for problematic tests.
> ------------------------------------------------------------------------
>
> Key: SOLR-15644
> URL: https://issues.apache.org/jira/browse/SOLR-15644
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The stuff in the test framework is slow and lacks control. For problematic
> tests, you don't want to linger first and you want fine control around
> interrupting - interrupting with a sledgehammer approach can actually make
> things take longer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
