[
https://issues.apache.org/jira/browse/SOLR-15644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419043#comment-17419043
]
Mark Robert Miller edited comment on SOLR-15644 at 9/23/21, 8:48 AM:
---------------------------------------------------------------------
If you haven’t fought all those issues you wouldn’t know. I didn’t and wouldn’t
either. Yes, you have broad control with the test framework. If you want to
spend the time to fix the tests and make them reasonably performant, you will
get to see how broad control doesn’t cut it. How did you first deal with Solr
with the thread leak control? You put in a universal 10 second linger. What did
that do? Set things up so that more and more tests abuse that linger. That’s
not what you want. You don’t even really want it at a test level. Too much goes
on in these tests. If you need to linger you want to deal with the individual
problems.
You don’t think there are thousands of issues because you don’t improve the
tests. You set a 10 second linger, others add additional layers on top, and
everything looks swell. Okay. Go turn off all of those exceptions and try to
make the tests stable and fast. If you were actually interested in the
problems and where this doesn’t give you the control needed to probably address
them that is what you would do. But you won’t.
was (Author: markrmiller):
If you haven’t fought all those issues you wouldn’t know. I didn’t and wouldn’t
either. Yes, you have broad control with the test framework. If you want to
spend the time to fix the tests and make them reasonably performant, you will
get to see how broad control doesn’t cut it. How did you first deal with Solr
with the thread leak control? You put in a universal 10 second linger. What did
that do? Set things up so that more and more tests absurd that linger. That’s
not what you want. You don’t even really want it at a test level. Too much goes
on in these tests. If you need to linger you want to deal with the individual
problems.
You don’t think there are thousands of issues because you don’t improve the
tests. You set a 10 second linger, others add additional layers on top, and
everything looks swell. Okay. Go turn off all of those exceptions and try to
make the tests stable and fast. If you were actually interested in the
problems and where this doesn’t give you the control needed to probably address
them that is what you would do. But you won’t.
> Add the ability to interrupt and wait for threads for problematic tests.
> ------------------------------------------------------------------------
>
> Key: SOLR-15644
> URL: https://issues.apache.org/jira/browse/SOLR-15644
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The stuff in the test framework is slow and lacks control. For problematic
> tests, you don't want to linger first and you want fine control around
> interrupting - interrupting with a sledgehammer approach can actually make
> things take longer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
