HoustonPutman commented on a change in pull request #324:
URL: https://github.com/apache/solr-operator/pull/324#discussion_r714940753
##########
File path: controllers/util/solr_util.go
##########
@@ -327,6 +328,13 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
}
}
+ // Default preStop hook
+ preStop := &corev1.Handler{
Review comment:
Yeah, if you look at
https://github.com/apache/solr-operator/blob/main/controllers/solrcloud_controller_test.go#L174,
you'll see we test basically all of the custom options there. Add the custom
lifecycle, and test that the podSpec actually uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
