dweiss commented on pull request #304: URL: https://github.com/apache/solr/pull/304#issuecomment-928199717
> I'm curious about what you think of the change suggested in this commit: allowing the lucene-dev-repo path to be explicitly specified (via system property), as opposed to supporting only a single default path I thought about it and even wanted to add it... but then I thought: occam's razor again... This is simpler, easier to document and doesn't require anything (adding build flags to gradle options in the IDE, for example). Will such a configurable property even be used? Something tells me it's adding functionality nobody will ever know about (or use). If you wanted to implement it, the "-P" (project property) should be the way to go and these are handled differently at the settings level and once the build actually run... so, again - hairy duplicated code for very little prospect of actual use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
