dweiss commented on a change in pull request #349:
URL: https://github.com/apache/solr/pull/349#discussion_r731069374



##########
File path: solr/core/build.gradle
##########
@@ -20,144 +20,158 @@ apply plugin: 'java-library'
 
 description = 'Apache Solr Core'
 
+configurations.all {

Review comment:
       I wouldn't do this. Blanket exclusions cause really painful headaches in 
trying to debug what's going on. Apply exclusions inside dependencies (you can 
reuse the same closure, if needed, but at the dependency declaration level - 
not at the configuration level).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to