janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738375211
##########
File path:
solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponseSerializer.java
##########
@@ -34,42 +33,32 @@
* <li>"Unknown" elements for the Javabin format will be serialized as
Strings. See {@link org.apache.solr.common.util.JavaBinCodec#writeVal}</li>
* </ul>
*/
- @SuppressWarnings("deprecation")
public static byte[] serialize(OverseerSolrResponse responseObject) {
Objects.requireNonNull(responseObject);
- if (useUnsafeSerialization()) {
- return SolrResponse.serializable(responseObject);
- }
try {
return Utils.toJavabin(responseObject.getResponse()).readAllBytes();
} catch (IOException|RuntimeException e) {
+ checkUnsafeSerializationProperty();
Review comment:
Hmm, this may never be necessary I suppose. This would be if the
overseer node is upgraded to 9.0 and the serialization fails.
Question is if we should throw exception here if the sysProp is set and
never send a response, or if we only need to check for this flag during
`deserialize()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
