[
https://issues.apache.org/jira/browse/SOLR-15815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447940#comment-17447940
]
Dawid Weiss commented on SOLR-15815:
------------------------------------
Yup, the approach looks fine to me. The only downside I see is that rules
defined this way would trigger for all tests (even if they don't use the rule).
Perhaps the logic inside that rule should be a lazy/ deferred evaluation (so
that if get() is called, it'll clean up the returned instance but otherwise is
a noop).
> Add TestRule support for ErrorLogMuter & LogListener
> ----------------------------------------------------
>
> Key: SOLR-15815
> URL: https://issues.apache.org/jira/browse/SOLR-15815
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15815.patch
>
>
> sibling sub-tasks implement log muting & inspection helpers that work by
> implementing AutoClosable, as discussed in parent task we should also expose
> this functionality in a TestRule
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
