[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section

[GitBox]

betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991874985


   > I suspect this is probably an existing bug (not introduced by the changes 
in this PR) (see screenshot), but if you supply the same parameter more than 
once, such as `stats.field` (to get stats for multiple fields), then the values 
get concatenated into a single comma-delimited list sent to the server like 
`"stats.field":"pages_i,price"`. <img alt="Screen Shot 2021-12-10 at 2 08 47 
PM" width="684" 
src="https://user-images.githubusercontent.com/417074/145645598-468774f8-6afd-460b-9854-daec7d2bf517.png";>
   > 
   > I'd like to see this bug fixed as part of this PR if you're up to it 
@betulince ? If not, we can tackle under another change / JIRA. I suspect is 
b/c the form is getting submitted 2x everytime I click the `Execute Query` 
button?!? The first time the query succeeds but then it re-submits with 
`"stats.field":"pages_i,price"` which fails. <img alt="Screen Shot 2021-12-10 
at 2 47 52 PM" width="537" 
src="https://user-images.githubusercontent.com/417074/145645596-31a2cd5a-9d1a-47f4-a9cf-fcb7d60d57ab.png";>
   > 
   > Also, line 51 is calling `addRawParams(urlParams[p]);` which doesn't exist?
   
   ![Screenshot from 2021-12-12 
13-47-38](https://user-images.githubusercontent.com/44343912/145709378-a853e6ed-0731-4c47-a3ec-f18ae4e0341d.png)
   
   Fixed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org