risdenk commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-1023680842
So current status as I see it: * render-javadoc needs a little more attention - basically shouldn't need so many changes * `Abstract*Base` test files moved to test-framework - not sure they are needed, but its a lot of the changes in this besides the move. I think all of the other comments from @dsmiley and @madrob have been addressed by @warperwolf I'm planning to look into the above a bit more tomorrow. @warperwolf, @dsmiley, @madrob any other comments/thoughts/concerns? Any other blockers to getting this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org