risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024422694
I went through these two and I'm not sure there is a good way to address
them right now. I don't think it should hold up the merge of this PR.
* render-javadoc needs a little more attention - basically shouldn't need so
many changes
* This is related to the bullet below. There were a few classes moved to
`test-framework` which ended up in a few more split packages. This should be
addressed for all of test-framework.
* Abstract*Base test files moved to test-framework - not sure they are
needed, but its a lot of the changes in this besides the move.
* This seems to be necessary due to how gradle and test dependencies end
up interacting. It matches the existing pattern of some test-framework classes.
The commit log has details about why each file was created/moved in
test-framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
