risdenk commented on a change in pull request #706:
URL: https://github.com/apache/solr/pull/706#discussion_r814804129
##########
File path: solr/solrj/src/java/org/apache/solr/common/util/Utils.java
##########
@@ -891,19 +918,20 @@ public static void reflectWrite(MapWriter.EntryWriter ew,
Object o) throws IOExc
for (FieldWriter fieldWriter : fieldWriters) {
try {
fieldWriter.write(ew, o);
- } catch( Throwable e) {
+ } catch (Throwable e) {
throw new RuntimeException(e);
- //should not happen
+ // should not happen
}
}
}
private static List<FieldWriter> getReflectData(Class<?> c) throws
IllegalAccessException {
boolean sameClassLoader = c.getClassLoader() ==
Utils.class.getClassLoader();
- //we should not cache the class references of objects loaded from packages
because they will not get garbage collected
- //TODO fix that later
- List<FieldWriter> reflectData = sameClassLoader ?
storedReflectData.get(c): null;
- if(reflectData == null) {
+ // we should not cache the class references of objects loaded from
packages because they will
+ // not get garbage collected
+ // TODO fix that later
Review comment:
Fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
