risdenk commented on a change in pull request #706:
URL: https://github.com/apache/solr/pull/706#discussion_r815942841
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -720,19 +749,21 @@ protected RouteException
getRouteException(SolrException.ErrorCode serverError,
NamedList<Object> cheader = new NamedList<>();
cheader.add("status", status);
cheader.add("QTime", timeMillis);
- if (rf != null)
- cheader.add(UpdateRequest.REPFACT, rf);
+ if (rf != null) cheader.add(UpdateRequest.REPFACT, rf);
if (null != toleratedErrors) {
cheader.add("maxErrors",
ToleratedUpdateError.getUserFriendlyMaxErrors(maxToleratedErrors));
cheader.add("errors", toleratedErrors);
if (maxToleratedErrors < toleratedErrors.size()) {
// cumulative errors are too high, we need to throw a client exception
w/correct metadata
- // NOTE: it shouldn't be possible for 1 == toleratedErrors.size(),
because if that were the case
+ // NOTE: it shouldn't be possible for 1 == toleratedErrors.size(),
because if that were the
+ // case
Review comment:
Fixed in eec4ea82f595a2cf78b6380e9900677b34bcea19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
