risdenk commented on a change in pull request #711: URL: https://github.com/apache/solr/pull/711#discussion_r818980739
########## File path: solr/core/src/test/org/apache/solr/cloud/TestHashPartitioner.java ########## @@ -86,28 +88,27 @@ public void testMapHashes() throws Exception { for (Range range : ranges) { int currStart = range.min; int currEnd = range.max; - assertEquals(lastEnd+1, currStart); + assertEquals(lastEnd + 1, currStart); if (ranges.size() < 4000) { // ranges should be rounded to avoid crossing hash domains assertEquals(defaultLowerBits, currEnd & defaultLowerBits); // given our rounding condition that domains should be less than 1/16 of the step size, - // this means that any sizing deviations should also be less than 1/16th of the idealized range size. + // this means that any sizing deviations should also be less than 1/16th of the idealized Review comment: I think this is correct. Line 100 is code so left it on a separate line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org