dsmiley commented on a change in pull request #708:
URL: https://github.com/apache/solr/pull/708#discussion_r825252854
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ZkClientClusterStateProvider.java
##########
@@ -39,9 +39,9 @@
volatile ZkStateReader zkStateReader;
private boolean closeZkStateReader = true;
- String zkHost;
- int zkConnectTimeout = 15000;
- int zkClientTimeout = 45000;
+ public String zkHost;
+ public int zkConnectTimeout = 15000;
Review comment:
These were being manipulated by utility methods. Those methods used to
be on BaseCloudSolrClient and were moved to a new class CloudSolrClientUtils.
This is a bit icky; I don't like making fields public, nor the mutability of
anything SolrClient related for that matter. @haythemkh shouldn't
CloudSolrClientUtils be in the same package maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
