janhoy commented on a change in pull request #708:
URL: https://github.com/apache/solr/pull/708#discussion_r825347816
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java
##########
@@ -358,4 +358,12 @@ public void setCacheTimeout(int cacheTimeout) {
// This exception is not meant to escape this class it should be caught and
wrapped.
private class NotACollectionException extends Exception {}
+
+ @Override
+ public String getQuorumHosts() {
+ if (this.liveNodes == null) {
+ return null;
+ }
+ return String.join(",", this.liveNodes);
Review comment:
Ah, so quorum here is either a list of zk hosts or a list of Solr hosts.
I get it. But what if Someone implements a state provider that gets state from
a Unix socket or something that is not hostname based?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
