cpoerschke commented on code in PR #796:
URL: https://github.com/apache/solr/pull/796#discussion_r853103746
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -461,7 +461,16 @@ private void searchWithTimeLimiter(final Query
filterQuery, Collector collector)
searcher.search(QueryUtils.combineQueryAndFilter(query, filterQuery),
collector);
} catch (TimeLimitingCollector.TimeExceededException
| ExitableDirectoryReader.ExitingReaderException x) {
- log.warn("Query: {}; ", query, x);
+ if (log.isWarnEnabled()) {
+ String queryToLog = query.toString();
+ if (queryToLog.length() > 1000) {
+ // INFO log long queries separately
+ log.info("Query: {}; ", query);
Review Comment:
yes, that was intended but actually looking at all this again now, the
info/warn split and separation of query/exception logging could potentially be
done always i.e. not only for long queries. pushed a commit for that
alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
