magibney commented on PR #794: URL: https://github.com/apache/solr/pull/794#issuecomment-1105477466
I'm seeing test "classMethod" test failures on one suite, which I think are related to this change. `gradlew :solr:core:test --tests "org.apache.solr.handler.TestReplicationHandler" -Ptests.jvms=6 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=1B1737D186075506 -Ptests.file.encoding=UTF-8` I think this is due to converting the explicit `core.close()` in the `finally` block into try-with-resources -- which reorders the try-with-resources core close to happen _before_ the `searcher.decref()` as opposed to after (where it had previously been). The above reproduces reliably for me locally. Could either revert from try-with-resources back to the manual close in the finally block (with null check), or move the finally block (`searcher.decref()` _inside_ the try-with-resouces). Both approaches fix the problem I'm seeing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
