cpoerschke commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925573261
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
Explicit `MatcherAssert.assertThat` seems quite intrusive, but that's of
course subjective.
Wondering if `import static org.hamcrest.MatcherAssert.assertThat;` might
provide a third alternative e.g. see
https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/modules/ltr/src/test/org/apache/solr/ltr/interleaving/algorithms/TeamDraftInterleavingTest.java
usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
