noblepaul commented on PR #965:
URL: https://github.com/apache/solr/pull/965#issuecomment-1208749089
> Which version of Java were you testing this with?
java 11
> I suspect that we want to de-duplicate the keys but not the values? Do the
values repeat across shards?
`state.json` has most Strings repeated even values. Take a look at the
sample below. Other than `base_url` and `range` almost all values can be safely
interned
```
{"prs1":{
"pullReplicas":"0",
"replicationFactor":"1",
"router":{"name":"compositeId"},
"maxShardsPerNode":"2048",
"autoAddReplicas":"false",
"nrtReplicas":"1",
"tlogReplicas":"0",
"shards":{
"shard1":{
"range":"80000000-80ffffff",
"state":"active",
"replicas":{"core_node3":{
"core":"prs1_",
"node_name":"10.0.0.49:8986_solr",
"base_url":"http://10.0.0.49:8986/solr";,
"state":"active",
"type":"NRT",
"force_set_state":"false",
"leader":"true"}}}}
```
> Was this measured using PRS or "traditional" state?
I tested with both and they're not very different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
