madrob commented on code in PR #965:
URL: https://github.com/apache/solr/pull/965#discussion_r959491853


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2424,6 +2430,34 @@ public PlacementPluginFactory<? extends 
PlacementPluginConfig> getPlacementPlugi
   public void runAsync(Runnable r) {
     coreContainerAsyncTaskExecutor.submit(r);
   }
+
+  public static void setWeakStringInterner() {
+    boolean enable = "true".equals(System.getProperty("use.str.intern", 
"true"));

Review Comment:
   This should be prefixed with solr.
   
   Maybe instead of true/false it would make sense to do strong/weak/off? No 
real opinion here, talking through ideas out loud to see how they sound... 
probably too much complexity and not worth it, but I'll leave that up to you. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to