[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #987: SOLR-16336: avoid fetching solrconfig.xml & schema.xml for already cached schema and config

Wed, 31 Aug 2022 06:35:28 -0700 


sonatype-lift[bot] commented on code in PR #987:
URL: https://github.com/apache/solr/pull/987#discussion_r959594973


##########
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##########
@@ -277,7 +277,7 @@ public ManagedIndexSchema create(
               managedSchemaResourceName,
               schemaZkVersion,
               getSchemaUpdateLock());

Review Comment:
   đŸ’Ŧ 11 similar findings have been found in this PR
   
   ---
   
   *THREAD_SAFETY_VIOLATION:*  Unprotected write. Non-private method 
`ManagedIndexSchemaFactory.create(...)` indirectly writes to field 
`config.overlay` outside of synchronization.
    Reporting because this access may occur on a background thread.
   
   ---
   
   <details><summary><b>🔎 Expand here to view all instances of this 
finding</b></summary><br/>
   
   <div align="center">
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java | 
[108](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java#L108)|
   | solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java | 
[118](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java#L118)|
   | solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java | 
[85](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java#L85)|
   | solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java | 
[51](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L51)|
   | solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java | 
[90](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java#L90)|
   | solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java | 
[95](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java#L95)|
   | solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java | 
[268](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L268)|
   | solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java | 
[541](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L541)|
   | solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java | 
[283](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L283)|
   | solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java | 
[290](https://github.com/fullstorydev/solr/blob/78f75d6c6313ea9f1fc2120827986877059993ae/solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java#L290)|
   <p> Showing <b>10</b> of <b>11</b> findings. <a 
href="https://lift.sonatype.com/results/github.com/apache/solr/01GBSYTGEW9BRGC230ZA68KQAY?t=Infer|THREAD_SAFETY_VIOLATION"
 target="_blank">Visit the Lift Web Console</a> to see all.</p></div></details>
   
   
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=325225072&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=325225072&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=325225072&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=325225072&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=325225072&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to