dsmiley commented on PR #1013: URL: https://github.com/apache/solr/pull/1013#issuecomment-1248188733
BTW I spot-checked the generated POM to observe the desired runtime dependency. > A CHANGES line is probably nice though, perhaps co-located with the original changes line? I disagree. This particular PR effectively augments the existing work that already has a CHANGES.txt. It's a branch specific implementation detail. Instead, I think maybe main should not only have an upgrade note but possible a mention of this difference in CHANGES.txt in its own section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
