janhoy commented on code in PR #1061:
URL: https://github.com/apache/solr/pull/1061#discussion_r994302604


##########
solr/core/src/java/org/apache/solr/handler/ClusterAPI.java:
##########
@@ -261,6 +257,13 @@ public void getNodes(SolrQueryRequest req, 
SolrQueryResponse rsp) {
     rsp.add("nodes", 
getCoreContainer().getZkController().getClusterState().getLiveNodes());
   }
 
+  @EndPoint(method = GET, path = "/cluster", permission = COLL_READ_PERM)

Review Comment:
   The `COLL_READ_PERM` (`collection-admin-read`) permission here stems from 
when CLUSTERSTATUS was a collection-api command.
   
   The content of clusterstatus is mostly collection data, i.e. a list of 
collections, their shards and replicas and their status. So I'm OK with keeping 
this permission although it is now located under`/api/cluster`. I'm thinking of 
the `CloudSolrClient` SolrJ client that will read cluster status in order to 
route index/search requests.
   
   Any thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to