NazerkeBS commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1035231912
########## solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java: ########## @@ -232,15 +230,20 @@ public void setConfigMetadata(String configName, Map<String, Object> data) throw @Override public Map<String, Object> getConfigMetadata(String configName) throws IOException { + byte[] data = null; try { - @SuppressWarnings("unchecked") - Map<String, Object> data = - (Map<String, Object>) - Utils.fromJSON(zkClient.getData(CONFIGS_ZKNODE + "/" + configName, null, null, true)); - return data; + data = zkClient.getData(CONFIGS_ZKNODE + "/" + configName, null, null, true); + } catch (KeeperException.NoNodeException e) { + return new HashMap<>(); Review Comment: previously NoNodeException is not checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org