epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1057783517
########## solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util; + +import java.io.IOException; +import java.lang.invoke.MethodHandles; +import java.nio.file.Path; +import org.apache.solr.client.solrj.SolrClient; +import org.apache.solr.client.solrj.SolrServerException; +import org.junit.rules.ExternalResource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * SolrClientTestRule is an abstract class that extends JUnit's {@link ExternalResource} class, + * which is a TestRule that allows for specifying methods to be run before and after a test. + * SolrClientTestRule provides access to a {@link SolrClient} instance. SolrClientTestRule should be + * used in tests that need to interact with a Solr server and provides a convenient way to manage Review Comment: Do we need more detail on Solr server? I.e, does this support solr cloud mode? Does this support http apis? ########## solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.util; + +import java.io.IOException; +import java.lang.invoke.MethodHandles; +import java.nio.file.Path; +import org.apache.solr.client.solrj.SolrClient; +import org.apache.solr.client.solrj.SolrServerException; +import org.junit.rules.ExternalResource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * SolrClientTestRule is an abstract class that extends JUnit's {@link ExternalResource} class, + * which is a TestRule that allows for specifying methods to be run before and after a test. + * SolrClientTestRule provides access to a {@link SolrClient} instance. SolrClientTestRule should be + * used in tests that need to interact with a Solr server and provides a convenient way to manage Review Comment: Do we need more detail on "Solr server"? I.e, does this support solr cloud mode? Does this support http apis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
